-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate asyncapi optimize library using the optimize command #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Kudos, SonarCloud Quality Gate passed! |
Thanks, @alceil looks great. when I use the optimize command, I expect it to show me the changes that are going to be applied and I should be able to chose between those changes. this is the flow that I expect to go through:
we definitely need some input about the UX from others here. |
Can I also get some inputs on the Ux as well. @KhudaDad414 . Im pretty new to this so I need some pointers as well on how to approach it |
from the UX perspective we need to support 2 ways of doing things:
does it make sense? |
Okay got it @derberg |
@alceil do you plan to continue working on it? Open Force ended but since you started during the event, it is ok if you complete work later |
Sure i wish to complete it . |
@alceil for UX, we are following CLIG, as mentioned in readme. As @KhudaDad414 mentioned, @alceil . I guess you are working on it, feel free if you feeling stuck anywhere. An idea that you can think for the implementation is using a
|
@alceil hey, this PR is opened for some time already, maybe we should close and you create new when ready? |
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
@KhudaDad414 hey, looks like oryginal contributor do not plan to continue with this one. Did you plan to integrate optimizer here in the CLI? |
I am putting it on my to-do list. thanks for reminding @derberg. |
I guess we should close this PR in favour of #397 |
closing since @alceil is no longer active here and @KhudaDad414 opened new PR |
Description
This PR integrates the asyncapi-optimize library using the optimize command.
At the moment, the command looks something like this.
asyncapi optimize <context/filepath/url>
And it has flag:
--format which determines the show the report or not.
Related issue(s)
Fixes #218